Start centralizing IDLs to reduce duplication and errors #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LintPassed |
|
*This report has been truncated because the total content is 2975844 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Firefox (nightly channel)Testing web-platform-tests at revision 3acd1b3 All results3 tests ran/XMLHttpRequest/interfaces.html
/dom/interfaces.html
|
|
*This report has been truncated because the total content is 3005938 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Chrome (unstable channel)Testing web-platform-tests at revision 3acd1b3 All results3 tests ran/XMLHttpRequest/interfaces.html
|
|
Notifying @Manishearth, @annevk, @caitp, @emilio, @hallvors, @ibelem, @jdm, @jungkees, @kangxu, @mathiasbynens, @ronkorving, @wisniewskit, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
|
This is really great! With this setup, I'm confident that we'd be able to use tooling that @mdittmer is building to compare IDLs to also update these IDL files whenever specs change. Perhaps it would then be helpful for each IDL file to link to its spec, but we can add that later. |
foolip
reviewed
Apr 26, 2017
XMLHttpRequest/interfaces.html
Outdated
| } | ||
|
|
||
| promise_test(function() { | ||
| // Have to wait for onload |
There was a problem hiding this comment.
Why do we need to wait for the load event?
There was a problem hiding this comment.
Um, cargo-culting? :) (I don't know why the original html/dom/interfaces.html does either, but maybe it's so that all the objects are properly initialized.) Fixed in new version.
foolip
approved these changes
Apr 26, 2017
Fixes web-platform-tests#5339 (or rather, starts to). We had two copies of the DOM IDL, one in dom/ and one in html/, which were out of sync. Additionally, tons of tests copy bits and pieces of IDLs from specs like DOM, or define stubs, instead of properly including the whole IDL. These should be fixed to include the whole IDL, because some tests may need to know about the entire base interface (e.g., testing that objects inherit properly). I chose to make the IDLs centralized because we might want to process them centrally in the future. For instance, we could have a script to update all of them, or a test that checks for non-standard properties on the global object and imports all the IDLs to get a list of standard properties. These seem easier to do if the IDLs are all in one place.
|
These tests are now available on w3c-test.org |
|
This broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5339 (or rather, starts to).
We had two copies of the DOM IDL, one in dom/ and one in html/, which
were out of sync. Additionally, tons of tests copy bits and pieces of
IDLs from specs like DOM, or define stubs, instead of properly including
the whole IDL. These should be fixed to include the whole IDL, because
some tests may need to know about the entire base interface (e.g.,
testing that objects inherit properly).
I chose to make the IDLs centralized because we might want to process
them centrally in the future. For instance, we could have a script to
update all of them, or a test that checks for non-standard properties on
the global object and imports all the IDLs to get a list of standard
properties. These seem easier to do if the IDLs are all in one place.
This change is