Disallow dialog.requestFullscreen() (includes web-platform-tests) #7504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 27, 2017
Build PASSEDStarted: 2017-09-28 14:00:14 View more information about this build on: |
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-684435
branch
from
c70f345
to
9fe1691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows whatwg/fullscreen#104
The compat risk is virtually none given how rarely this happens:
https://www.chromestatus.com/metrics/feature/timeline/popularity/1998
https://www.chromestatus.com/metrics/feature/timeline/popularity/1999
Bug: 240576
Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f
Reviewed-on: https://chromium-review.googlesource.com/684435
Reviewed-by: Takayoshi Kochi kochi@chromium.org
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#505007}