WPT tests for setRemoteDescription for adding and removing tracks. #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 15, 2017
Build PASSEDStarted: 2017-10-19 18:31:20 Failing Jobs
View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-719615
branch
5 times, most recently
from
bb916a6
to
2b55602
Compare
These are behavior-driven tests, each test testing a specific behavior: - addTrack() with a track and no stream should fire ontrack with a remote track with the same ID and no streams. - addTrack() with a track and a stream should fire ontrack with a remote track and stream with matching IDs. - addTrack() with two tracks and a shared stream should fire ontrack twice with remote tracks and a shared remote stream, with matching IDs. - addTrack() with a track and two streams should fire ontrack with a track and two streams with matching IDs. - ontrack should fire before setRemoteDescription()'s promise resolves. - ontrack's receiver should match getReceivers(). - removeTrack() should not result in a receiver being removed. Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on transceiver support. When testing a behavior like "fires an event with a track" the test does not test unrelated things like the event being a complete implementation of RTCTrackEvent with transceivers and all. In a follow-up, I will add tests for other behavior associated with the removal of a track, including onmute events firing and the track being removed from the remote streams. Bug: 774303 Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f Reviewed-on: https://chromium-review.googlesource.com/719615 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#510241}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-719615
branch
from
2b55602
to
e2115d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are behavior-driven tests, each test testing a specific behavior:
remote track with the same ID and no streams.
remote track and stream with matching IDs.
twice with remote tracks and a shared remote stream, with matching
IDs.
track and two streams with matching IDs.
Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on
transceiver support. When testing a behavior like "fires an event with
a track" the test does not test unrelated things like the event being a
complete implementation of RTCTrackEvent with transceivers and all.
In a follow-up, I will add tests for other behavior associated with the
removal of a track, including onmute events firing and the track being
removed from the remote streams.
Bug: 774303
Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f
Reviewed-on: https://chromium-review.googlesource.com/719615
Commit-Queue: Henrik Boström hbos@chromium.org
Reviewed-by: Taylor Brandstetter deadbeef@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#510241}