Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and improve keypath tests for IndexedDB #831

Merged

Conversation

yunxiaoxie
Copy link
Contributor

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1162

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

zqzhang added a commit that referenced this pull request Apr 3, 2014
Move and improve keypath tests for IndexedDB
@zqzhang zqzhang merged commit 9ce5fbd into web-platform-tests:master Apr 3, 2014
@@ -11,40 +11,35 @@
<script>
function keypath(keypath, objects, expected_keys, desc) {
var db,
t = async_test(document.title + " - " + (desc ? desc : keypath), { timeout: 10000 });
t = async_test(document.title + " - " + (desc ? desc : keypath), { timeout: 10000 }),
store_name = "store-" + (Date.now()) + Math.random(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you do this change? The database name that createdb() creates should always be unique, -- so there shouldn't be a reason to have different objectstore names?

(Yeah, I know this is already merged, -- I just wanted to ask about it :) )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, I will make a pull request to resurrect the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants