create separate security and privacy considerations sections #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
I think Timing Attacks is also a privacy consideration. Otherwise, LGTM. It seems fine to split these sections even if w3c/specberus#1346 concludes that it's not actually required.
LOL indeed it is, I guess I didn't actually read it in my rush the first time around 🤪 fixed in c04caaf |
github-actions bot
added a commit
that referenced
this pull request
Jan 19, 2022
SHA: 466e853 Reason: push, by @equalsJeffH Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
This PR indeed fixed the editors' draft spec publishing problem that instigated issue #186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very quickly done separation of section 6. Security and Privacy Considerations into two separate "security cons" and "privacy cons" sections in order to get our editors' draft to be published.
upon a quick scan it seemed the last two subsections were the only privacy-oriented ones, so I carved them into the new "privacy cons" section.
This will need review and polishing no doubt, but hopefully will re-instate editors' draft auto-updating.
fixes #186
Preview | Diff