Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new algorithms to create a Feature Policy before document is c… #324

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

dtapuska
Copy link
Contributor

…reated.

Adjust algorithms so that the HTML spec will be able to create a feature
policy before the document is created. Instead of creating the document
first and then applying it afterwards. The document based algorithms
will remain until the HTML spec is changed.

…reated.

Adjust algorithms so that the HTML spec will be able to create a feature
policy before the document is created. Instead of creating the document
first and then applying it afterwards. The document based algorithms
will remain until the HTML spec is changed.
Copy link
Collaborator

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this -- splitting up the creation from actually assigning to document is a good idea, and I hope that assigning can be done in HTML eventually, since that's where a document's policy is actually declared.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; one tiny nit remains, but otherwise I'm okay with merging this.

index.bs Outdated Show resolved Hide resolved
@clelland clelland merged commit 0d8f9c0 into w3c:master Jul 16, 2019
domenic pushed a commit to whatwg/html that referenced this pull request Jul 18, 2019
Instead of delegating to the feature policy spec to initialize feature
policy after the document is created, initialize feature policy first
and pass it in while constructing the document.

This uses w3c/webappsec-permissions-policy#324.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants