exclude/allowCredentials state different defaults in definition vs description

[emlun]

The definitions state:

    sequence<PublicKeyCredentialDescriptor>      excludeCredentials = [];
    sequence<PublicKeyCredentialDescriptor>      allowCredentials = [];

But the descriptions state:

excludeCredentials, of type sequence<PublicKeyCredentialDescriptor>, defaulting to None
allowCredentials, of type sequence<PublicKeyCredentialDescriptor>, defaulting to None

Which is correct?

[equalsJeffH]

I think the definitions are correct, IIRC. bikeshed perhaps is misunderstanding what to state in the descriptions. this may have been caused by a webidl-driven auto-spec edit, have to look into that....

[emlun]

Looks like this goes back to the very beginnings of the spec, it's not a recent change: https://www.w3.org/TR/2017/WD-webauthn-20170505/#dom-publickeycredentialrequestoptions-allowlist

The earliest spec version with the [] default is https://www.w3.org/TR/2017/WD-webauthn-20170216/#dom-assertionoptions-allowlist, but that doesn't use the same definition header.

[emlun]

Digging deeper, this seems like a bug in Bikeshed: speced/bikeshed#1592

[emlun]

This is now fixed upstream, so any builds with a fresh Bikeshed installation should be good. I'll keep an eye on the editor's draft and close this once the fix shows up there.

[equalsJeffH]

thx @emlun, do we need to manually update the travis machinery to use the latest bikeshed?

[emlun]

I don't think so, the Travis build should be using the latest Bikeshed version as far as I can tell. Unless the install step is cached, but it looks like it's not.

webauthn/.travis.yml

Line 19 in 6349d24

- git clone --depth=100 --branch=master https://github.com/tabatkins/bikeshed.git ./bikeshed

[emlun]

This is now fixed in the working draft.