Conditional request allowList credential filtering #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
reviewed
Oct 3, 2022
|
Looks great to me :) |
agl
approved these changes
Oct 4, 2022
emlun
approved these changes
Oct 5, 2022
pascoej
approved these changes
Oct 5, 2022
|
From the call: Nina to merge after fixing the merge errors. |
Allow filtering credentials during conditional requests by passing an allowList to navigator.credentials.get. This allows relying parties who know who the user attempting to authenticate is (e.g. because they entered their username) to have autofill only show credentials for that user. See the bug for a description of use-cases. Fixes w3c#1793
nsatragno
force-pushed
the
autofill_filtering
branch
from
6a69016
to
c7b8940
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 7, 2022
SHA: 8a6daec Reason: push, by @nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to nsatragno/webauthn
that referenced
this pull request
Oct 7, 2022
SHA: 8a6daec Reason: push, by @nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow filtering credentials during conditional requests by passing an
allowListtonavigator.credentials.get. This allows relying parties who know who the user attempting to authenticate is (e.g. because they entered their username) to have autofill only show credentials for that user. See the bug for a description of use-cases.Fixes #1793
Preview | Diff