-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge #1887 into main #1906
Merge #1887 into main #1906
Conversation
The WebAuthn API provides accessors to get the SPKI-formatted public key and authenticator data without needing to parse CBOR or handle COSE. However, the JSON structures, prior to this change, didn't include these values giving users an unfortunate choice: either use the accessors and do the JSON encoding yourself, or use the provided `toJSON` function. But we can have both!
Co-authored-by: Emil Lundberg <emil@yubico.com>
Include the "Easily accessing credential data" fields in JSON.
I'll take the opportunity to tag this for inclusion in this PR too: #1887 (comment)
I can draft the proposed change. |
Requesting @agl to review commit fe4d21f6cf374c2a6d726d1e0644c10acbf3e06d in particular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching that.
SHA: de9ca6b Reason: push, by MasterKale Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I didn't catch before merging it that #1887 sought to merge a "jsoneasy" branch into a "json" branch. I think it was intended to target "main" branch, though, so I went ahead and did that here.
Preview | Diff