Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #1887 into main #1906

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Merge #1887 into main #1906

merged 6 commits into from
Jun 28, 2023

Conversation

MasterKale
Copy link
Contributor

@MasterKale MasterKale commented Jun 14, 2023

I didn't catch before merging it that #1887 sought to merge a "jsoneasy" branch into a "json" branch. I think it was intended to target "main" branch, though, so I went ahead and did that here.


Preview | Diff

agl and others added 5 commits May 4, 2023 10:24
The WebAuthn API provides accessors to get the SPKI-formatted public key
and authenticator data without needing to parse CBOR or handle COSE.
However, the JSON structures, prior to this change, didn't include these
values giving users an unfortunate choice: either use the accessors and
do the JSON encoding yourself, or use the provided `toJSON` function.

But we can have both!
Co-authored-by: Emil Lundberg <emil@yubico.com>
Include the "Easily accessing credential data" fields in JSON.
@MasterKale MasterKale requested a review from emlun June 14, 2023 19:57
@emlun
Copy link
Member

emlun commented Jun 14, 2023

I'll take the opportunity to tag this for inclusion in this PR too: #1887 (comment)

I realize belatedly that we probably also need instructions on how to populate these new fields, like we have for clientExtensionResults and transports:

webauthn/index.bs

Lines 1592 to 1602 in 6dfbdba

The
{{RegistrationResponseJSON/clientExtensionResults|RegistrationResponseJSON.clientExtensionResults}} or
{{AuthenticationResponseJSON/clientExtensionResults|AuthenticationResponseJSON.clientExtensionResults}}
member MUST be set to the output of {{PublicKeyCredential/getClientExtensionResults()}},
with any {{ArrayBuffer}} values encoded to {{DOMString}} values using
[=base64url encoding=]. This MAY include {{ArrayBuffer}} values from extensions registered
in the IANA "WebAuthn Extension Identifiers" registry [[!IANA-WebAuthn-Registries]] but not
defined in [[#sctn-extensions]].
The {{AuthenticatorAttestationResponseJSON/transports|AuthenticatorAttestationResponseJSON.transports}}
member MUST be set to the output of {{AuthenticatorAttestationResponse/getTransports()}}.

I'll open a follow-up PR.

I can draft the proposed change.

@emlun
Copy link
Member

emlun commented Jun 14, 2023

Requesting @agl to review commit fe4d21f6cf374c2a6d726d1e0644c10acbf3e06d in particular.

@emlun emlun requested a review from agl June 14, 2023 20:06
Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that.

@MasterKale MasterKale merged commit de9ca6b into main Jun 28, 2023
@MasterKale MasterKale deleted the json branch June 28, 2023 19:17
github-actions bot added a commit that referenced this pull request Jun 28, 2023
SHA: de9ca6b
Reason: push, by MasterKale

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nadalin nadalin added this to the L3-WD-01 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants