Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SPK's signatures output as required. #2011

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Mark SPK's signatures output as required. #2011

merged 1 commit into from
Jan 10, 2024

Conversation

agl
Copy link
Contributor

@agl agl commented Jan 2, 2024

AuthenticationExtensionsSupplementalPubKeysOutputs.signatures should always be present in the client extension outputs since it's the only field and SPK makes no sense without the signatures.


Preview | Diff

AuthenticationExtensionsSupplementalPubKeysOutputs.signatures should
always be present in the client extension outputs since it's the only
field and SPK makes no sense without the signatures.
@timcappalli timcappalli self-requested a review January 3, 2024 19:13
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadalin nadalin added this to the L3-WD-02 milestone Jan 3, 2024
@agl agl merged commit 759221b into main Jan 10, 2024
2 checks passed
@emlun emlun deleted the spkrequired branch January 10, 2024 20:24
Copy link
Contributor

@ve7jtb ve7jtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

github-actions bot added a commit that referenced this pull request Jan 10, 2024
SHA: 759221b
Reason: push, by agl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants