Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of audio sample types #256

Merged
merged 4 commits into from May 27, 2021
Merged

Add description of audio sample types #256

merged 4 commits into from May 27, 2021

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented May 25, 2021

Noteworthy things:

  • Added U8P
  • Added S24 variant. Otherwise, there is no way to distinguish between 24bit audio sample and 32bit audio samples (this exists, in WAV). This follows what ffmpeg and others do.

Otherwise, probably what you'd have expected.


Preview | Diff

@padenot padenot force-pushed the 215-audio-sample-types branch 3 times, most recently from 6626041 to ebab726 Compare May 25, 2021 17:26
@dalecurtis
Copy link
Contributor

Technical details lgtm, but defer to @chcunningham for spec wording.

Copy link
Collaborator

@chcunningham chcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great! I only had nits.

index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
@padenot
Copy link
Collaborator Author

padenot commented May 26, 2021

@chcunningham I've added another commit on top of the commit addressing the comments you had. Nothing controversial. The failure above will be fixed once I rebase on top of #228 (that itself needs to be rebased), because I'll reference the definition of a frame.

@chcunningham
Copy link
Collaborator

chcunningham commented May 26, 2021

Editors call: @aboba lgtm. @padenot plan above SGTM. #288 now rebased and merged.

Add a definition for sample, frame, and say that all samples are linear
PCM like the Web Audio API.

The frame definition is not referenced for now, but will be used in
other PRs (e.g. when decribing AudioFrame methods).
@padenot
Copy link
Collaborator Author

padenot commented May 27, 2021

This is now rebased, and I've linked the concept of a frame in copyTo definitions and elsewhere, merging.

@padenot padenot merged commit e36bf7a into main May 27, 2021
@padenot padenot deleted the 215-audio-sample-types branch May 27, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants