Add description of audio sample types #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padenot
force-pushed
the
215-audio-sample-types
branch
3 times, most recently
from
6626041
to
ebab726
Compare
|
Technical details lgtm, but defer to @chcunningham for spec wording. |
dalecurtis
approved these changes
May 25, 2021
chcunningham
approved these changes
May 25, 2021
|
@chcunningham I've added another commit on top of the commit addressing the comments you had. Nothing controversial. The failure above will be fixed once I rebase on top of #228 (that itself needs to be rebased), because I'll reference the definition of a |
This fixes #215.
Add a definition for sample, frame, and say that all samples are linear PCM like the Web Audio API. The frame definition is not referenced for now, but will be used in other PRs (e.g. when decribing AudioFrame methods).
padenot
force-pushed
the
215-audio-sample-types
branch
from
980e15b
to
3a8b026
Compare
|
This is now rebased, and I've linked the concept of a frame in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteworthy things:
U8PS24variant. Otherwise, there is no way to distinguish between 24bit audio sample and 32bit audio samples (this exists, in WAV). This follows what ffmpeg and others do.Otherwise, probably what you'd have expected.
Preview | Diff