New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of audio sample types #256
Conversation
6626041
to
ebab726
Compare
Technical details lgtm, but defer to @chcunningham for spec wording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great! I only had nits.
@chcunningham I've added another commit on top of the commit addressing the comments you had. Nothing controversial. The failure above will be fixed once I rebase on top of #228 (that itself needs to be rebased), because I'll reference the definition of a |
This fixes #215.
Add a definition for sample, frame, and say that all samples are linear PCM like the Web Audio API. The frame definition is not referenced for now, but will be used in other PRs (e.g. when decribing AudioFrame methods).
980e15b
to
3a8b026
Compare
This is now rebased, and I've linked the concept of a frame in |
Noteworthy things:
U8P
S24
variant. Otherwise, there is no way to distinguish between 24bit audio sample and 32bit audio samples (this exists, in WAV). This follows what ffmpeg and others do.Otherwise, probably what you'd have expected.
Preview | Diff