Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uperrors: change timeout errors from 408 to 500 HTTP status code #1292
Conversation
andreastt
added
the
bug
label
Aug 21, 2018
andreastt
requested review from
AutomatedTester,
jgraham and
shs96c
as
code owners
Aug 21, 2018
andreastt
added
the
requires test
label
Aug 21, 2018
This comment has been minimized.
This comment has been minimized.
|
This change is backwards incompatible but we need a fix for this in order to support Keep-Alive and persistent connections. This PR can’t land until we have tests ready and I will supply these downstream in https://bugzilla.mozilla.org/show_bug.cgi?id=1484941. |
This comment has been minimized.
This comment has been minimized.
|
@AutomatedTester The tests have landed. |
AutomatedTester
merged commit c377c21
into
w3c:master
Sep 3, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
andreastt commentedAug 21, 2018
Whilst it is logically correct to use 408 for the timeout and script
timeout errors, it causes a collision with HTTP semantics implement
in HTTP clients. To support Keep-Alive we allow retries in HTTP
clients and if a client sees code 408 it thinks that the server has
gone away and retries the request.
This causes Execute Script, Navigate To, and Refresh commands to
be sent twice with some HTTP clients.
This is a backwards incompatible change to WebDriver in order to
not break HTTP/1.1 Keep-Alive.
Fixes: #1287