Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatherer state vs gathering state #1959

Closed
steveanton opened this issue Aug 10, 2018 · 3 comments
Closed

Gatherer state vs gathering state #1959

steveanton opened this issue Aug 10, 2018 · 3 comments
Assignees
Labels

Comments

@steveanton
Copy link

The RTCIceTransport has an attribute gatheringState of type RTCIceGathererState. It also fires an event of type icegatheringstatechange.

Would it make sense to use the same name for the enum and the attribute/event type?

Proposal:

  • Change gatheringState to gathererState
  • Change icegatheringstatechange to icegathererstatechange (and associated event handler attribute)
@steveanton
Copy link
Author

I see now that we have both enums RTCIceGatheringState and RTCIceGathererState. The former aggregating the latter over possibly many ICE transports in a PeerConnection.

@fippo
Copy link
Contributor

fippo commented Aug 10, 2018

that sounds like it came from ORTC. @aboba ^^

@aboba
Copy link
Contributor

aboba commented Aug 10, 2018

@steveanton Within the RTCIceTransport object, we have RTCIceGathererState gatheringState to express the gathering state of an individual RTCIceTransport, and an ongatheringstatechange EventHandler for when the state changes. Within the RTCPeerConnection we have RTCIceGatheringState iceGatheringState which represents the aggregate gathering state, and an onicegatheringstatechange EventHandler for when the state changes. While the enum values are the same, the meanings are different. In ORTC's RTCIceGatherer, we have RTCIceGathererState state and an onstatechange EventHandler.

@aboba aboba added the question label Aug 10, 2018
@aboba aboba self-assigned this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants