New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to define what to do on very low bitrates #2003
Comments
and what if the bitrate is reasonable for the track currently attached to the sender (says 320x240@15fps) and then that track is replaced with a 4k@30fps screenshare? |
This situation is no different than setting the bitrate to a reasonable value end then getting a BWE with a very low bitrate. IMO, the implementation should never be allowed to send more bitrate than the specified on the parameters or the value provided by the BWE. In this case the implementation could either decide to not send media at all, or try to send it a very low fps (one frame each several seconds). |
Agree that the configured bitrate (and the bitrate from BWE) should never be exceeded when averaged over a long enough period. (But what's long enough?) |
A relevant webrtc bug: |
Regarding this issue, should we treat maxBitrate == 0 the same as maxFramerate == 0 for consistency? |
Fixes #2003 This is a non-normative note, so shouldn't need tests.
If bitrate is so low that it's unreasonable (doesn't allow sending a frame in a reasonable time), is the implementation allowed to emit a frame at all, is it allowed to exceed the bitrate over a short interval, or should it reject the parameter?
The text was updated successfully, but these errors were encountered: