-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using new issue labels #2019
Comments
WebRTC 1.0/Post WebRTC 1.0 sound great to me. I am less sure about the meaning of 'Has WPT issue'. |
We want to ensure test coverage for everything, but I don't think we should block a PR from landing because the test coverage has not been added yet, but we could block it from landing unless there is a corresponding WPT issue to add coverage for it. We could assign WPT issues as part of issue duties to make sure that list does not grow over time. |
In terms of ensuring ourselves we have test coverage such a label would make it clear what has or has not been covered by WPT issues - at least going forward. |
Yes, we should allow landing a PR as soon as its testability is documented and agreed. I would think 'Needs Test' would cover this case, and would also cover the case of other forms of testing (manual test, KITE...). |
"Enhancement" or "Icebox" are the labels we have been using for things that are beyond the scope of WebRTC 1.0. Other issues are assumed to relate to WebRTC 1.0 (since they are filed in the webrtc-pc repository). |
There is also "LATER" that might be similar to these two. Mentioning clearly WebRTC 1.0 (or WebRTC 1.0 PR) might make things clearer and it would be nice to know which are the mandatory issue to close for PR. Quickly going through the list: |
I don't like "post 1.0" as a label - I'd prefer "WebRTC NV". Always focus on where you're going, not on where you've been... |
Change label "enhancement" to "WebRTC NV". |
@henbos to put a document somewhere (README file?) to say what to do with the labels. We discussed: "Needs Test" for things needing non-WPT tests, filing issues on WPT for things that needs WPT tests, and using a "WebRTC 1.0" and "WebRTC NV" |
Suggested labels:
The text was updated successfully, but these errors were encountered: