Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using new issue labels #2019

Closed
henbos opened this issue Oct 30, 2018 · 9 comments
Closed

Start using new issue labels #2019

henbos opened this issue Oct 30, 2018 · 9 comments
Assignees

Comments

@henbos
Copy link
Contributor

henbos commented Oct 30, 2018

Suggested labels:

  • "WebRTC 1.0"
  • "Post WebRTC 1.0"
  • "Has WPT issue"
@youennf
Copy link
Contributor

youennf commented Oct 30, 2018

WebRTC 1.0/Post WebRTC 1.0 sound great to me.
I guess the goal would be to iterate through all existing issues as well as any newly filed issue.

I am less sure about the meaning of 'Has WPT issue'.
Do we want to flag PRs that have missing test coverage?
Do we want for every PRs (or issue triggering a PR) to have some comments describing the testing status?

@henbos
Copy link
Contributor Author

henbos commented Oct 30, 2018

We want to ensure test coverage for everything, but I don't think we should block a PR from landing because the test coverage has not been added yet, but we could block it from landing unless there is a corresponding WPT issue to add coverage for it.

We could assign WPT issues as part of issue duties to make sure that list does not grow over time.

@henbos
Copy link
Contributor Author

henbos commented Oct 30, 2018

In terms of ensuring ourselves we have test coverage such a label would make it clear what has or has not been covered by WPT issues - at least going forward.

@youennf
Copy link
Contributor

youennf commented Oct 30, 2018

Yes, we should allow landing a PR as soon as its testability is documented and agreed.
Filing a WPT issue and linking the PR with it sounds good enough to me.

I would think 'Needs Test' would cover this case, and would also cover the case of other forms of testing (manual test, KITE...).

@aboba
Copy link
Contributor

aboba commented Oct 30, 2018

"Enhancement" or "Icebox" are the labels we have been using for things that are beyond the scope of WebRTC 1.0. Other issues are assumed to relate to WebRTC 1.0 (since they are filed in the webrtc-pc repository).

@youennf
Copy link
Contributor

youennf commented Oct 30, 2018

There is also "LATER" that might be similar to these two.
It is not clear whether "Question" is in or out of scope(maybe these need investigation to understand whether 1.0 or not). Ditto for "Editorial".

Mentioning clearly WebRTC 1.0 (or WebRTC 1.0 PR) might make things clearer and it would be nice to know which are the mandatory issue to close for PR.

Quickly going through the list:
#2012 seems like an improvement.
#1979 could be marked post 1.0?
#1918 might be "post 1.0" as well
#1742/#1727 might require coordination with other WGs (might take time). It is not clear whether this is mandatory for WebRTC 1.0 or not. From the lack of labels, I would think it is mandatory to fix this.

@alvestrand
Copy link
Contributor

I don't like "post 1.0" as a label - I'd prefer "WebRTC NV". Always focus on where you're going, not on where you've been...

@alvestrand
Copy link
Contributor

Change label "enhancement" to "WebRTC NV".

@henbos henbos self-assigned this Dec 6, 2018
@henbos
Copy link
Contributor Author

henbos commented Dec 6, 2018

@henbos to put a document somewhere (README file?) to say what to do with the labels. We discussed: "Needs Test" for things needing non-WPT tests, filing issues on WPT for things that needs WPT tests, and using a "WebRTC 1.0" and "WebRTC NV"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants