Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the configuration is unnecessarily checking for some members being set #2142

Open
youennf opened this Issue Mar 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@youennf
Copy link
Contributor

commented Mar 24, 2019

https://w3c.github.io/webrtc-pc/#set-the-configuration in step 5 is saying:
"If the value of configuration.bundlePolicy is set ..."

This check seems to suggest that the following is allowed:
const pc = new RTCPeerConnection({bundlePolicy: "max-compat"})
pc.setConfiguration({}); // Should not throw.

Given that bundlePolicy takes a default value of "balanced", I would think that configuration.bundlePolicy will always have a value so the above example should fail.

Two options could be envisioned:

  • Clarify that this is not allowed by removing the "If the value..." statement in the spec.
  • Allow this by removing the default value of bundlePolicy.

The same might apply to rtcpMuxPolicy and iceTransportPolicy.

@alvestrand

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Youenn, can you propose a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.