Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCPeerConnectionIceErrorEvent: hostCandidate clarification #2230

Closed
aboba opened this issue Jul 16, 2019 · 4 comments

Comments

@aboba
Copy link
Contributor

commented Jul 16, 2019

Currently, the explanatory test for hostCandidate states:

"The hostCandidate attribute is the local IP address and port used to communicate with the STUN or TURN server.

On a multihomed system, multiple interfaces may be used to contact the server, and this attribute allows the application to figure out on which one the failure occurred.

If use of multiple interfaces has been prohibited for privacy reasons, this attribute will be set to 0.0.0.0:0 or [::]:0, as appropriate."

Is an mDNS name ever placed in the hostCandidate field?

@aboba aboba assigned aboba and youennf and unassigned aboba Jul 18, 2019
@youennf

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

There does not seem to be any privacy issue since only mode 1 is allowing multiple interfaces and host candidates should already have exposed the IP address.
I would tend though to make it consistent with other parts of the spec and state that this field must remain null as long as the corresponding address is not already exposed to the web page as a host candidate.

This could for instance leak information in a weird case where only STUN/TURN is allowed but on multiple interfaces.

It seems that Chrome might be implementing this, @alvestrand, @tQsW?
Would it be possible to consider switching to a "DOMString? hostCandidate"?
Also, is it too late to have the port as another member field for consistency with other places, hence hostAddress, hostPort?

@aboba aboba added the TPAC 2019 label Aug 8, 2019
@alvestrand alvestrand added this to To do in WebRTC 1.0 to PR Aug 22, 2019
@dontcallmedom

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

RESOLUTION: empty string for null value, split port separately
(make port nullable, find proper name for host attribute)

@jan-ivar

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

@youennf to provide PR

@dontcallmedom

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

I believe this was addressed by #2322 so closing

WebRTC 1.0 to PR automation moved this from To do to Done Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.