Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degradationPreference is under-specified #2248

Open
aboba opened this issue Aug 1, 2019 · 4 comments

Comments

@aboba
Copy link
Contributor

commented Aug 1, 2019

degradationPreference appears to have been implemented differently between browsers, but the
differences are not being picked up in the WPT test, which only tests getting and setting values.

Currently Section 5.2.2 says:
"When bandwidth is constrained and the RTCRtpSender needs to choose between degrading resolution or degrading framerate, degradationPreference indicates which is preferred."

In the current Edge implementation, degradationPreference is interpreted as providing a content-hint to the encoder, allowing it to differentiate between applications desiring a bias toward "detail" (a degradationPreference of "maintain-resolution" or "motion" (a degradation-preference of "maintain-framerate").

However my understanding is that other browsers don't implement degradationPreference this way.

@aboba aboba self-assigned this Aug 1, 2019
@Orphis

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

As for Chrome, it's not exposed right now since we are still tuning the balanced degradation preference which is supposed to be the default. We also default internally to "maintain framerate", so we'd be changing the current default behavior in lots of apps, which is tricky to handle.

I don't think we've had any issues interpreting the behavior of the flag though. "Maintain framerate" will try to adapt the frame size to keep the transmission smooth, "maintain resolution" will not change the frame size but drop frames as needed.

@aboba aboba added the TPAC 2019 label Aug 8, 2019
@aboba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@Orphis Is it accurate to say that in the Chrome implementation degradationPreference is orthogonal to content-hints? That is, there is no interaction between a degradation-preference of "maintain-framerate" and a content-hint of "detail" (or between a degradation-preference of "maintain-resolution" and a content-hint of "motion")?

@Orphis

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

@aboba I believe that is correct.

@aboba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Some of the concerns described here may also apply to degradationPreference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.