New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a bitrate definition #267

Closed
alvestrand opened this Issue Aug 20, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@alvestrand
Copy link
Contributor

alvestrand commented Aug 20, 2015

#254 defines a max bitrate, but there isn't a definition for the term in the spec. Need to point to one (preferably one that the IETF agrees is relevant).

@alvestrand

This comment has been minimized.

Copy link
Contributor

alvestrand commented Aug 25, 2015

One possibility is to reuse the TIAS definition from RFC 3890 section 6.2.2.

Note that this definition doesn't say what period it's calculated over, nor does it say how to deal with undershoots and overshoots. If the IETF can live without these parts of the definition, can the W3C do likewise?

@juberti

This comment has been minimized.

Copy link
Contributor

juberti commented Aug 26, 2015

TIAS seems like the clear winner out of all the possible bitrate specifications. Agree the details can be left somewhat vague for now.

dontcallmedom added a commit that referenced this issue Oct 16, 2015

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Nov 19, 2015

Here is some proposed text based on RFC 3890 Section 6.2.2:

The Transport Independent Application Specific Maximum (TIAS) bandwidth .... is the maximum [amount of bandwidth needed when all declared media streams are used] ... without counting IP or other transport layers like TCP or UDP.... This can be less than the sum of all the individual media streams values... [since] not all streams have their maximum at the same point in time.

@alvestrand

This comment has been minimized.

Copy link
Contributor

alvestrand commented Nov 19, 2015

The discussion at TPAC and IETF invoked the question of what timeframe we should look for a bitrate to be satisfied over - one second was proposed, but seemed to be thought a bit arbitrary. (Obviously it's not smooth at timescales less than the video frame size or audio packet time.)

@alvestrand alvestrand removed the TPAC topic label Nov 19, 2015

aboba added a commit that referenced this issue Nov 25, 2015

@aboba aboba added the PR exists label Nov 25, 2015

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Nov 25, 2015

Left in the note about "TODO: Find or create a definition for bitrate (how much header overhead is included, for example). Should be aligned with RTCOutboundRTPStreamStats.targetBitrate in webrtc-stats.". Do we need another PR for targetBitrate?

@alvestrand alvestrand closed this Nov 25, 2015

aboba added a commit to w3c/ortc that referenced this issue Nov 28, 2015

Fix for Issue 267 Bitrate definition
This is a fix for WebRTC 1.0 Issue 267:
w3c/webrtc-pc#267

Fixed in the following WebRTC 1.0 PR: 
w3c/webrtc-pc#401

aboba added a commit to w3c/ortc that referenced this issue Nov 28, 2015

aboba added a commit to w3c/ortc that referenced this issue Nov 28, 2015

Add RFC 3890 to references
Relates to WebRTC 1.0 Issue 267: 
w3c/webrtc-pc#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment