New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty step 7 in replaceTrack algo #598

Closed
stefhak opened this Issue Apr 27, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@stefhak
Contributor

stefhak commented Apr 27, 2016

Step 7 says
If sender is not represented in localDescription, then set sender's track attribute to withTrack, and resolve p with undefined.
However, p is only introduced in step 8.

@adam-be

This comment has been minimized.

Show comment
Hide comment
@adam-be

adam-be Apr 27, 2016

Member

True. It should return a promise rejected with a TypeError.

Member

adam-be commented Apr 27, 2016

True. It should return a promise rejected with a TypeError.

@adam-be

This comment has been minimized.

Show comment
Hide comment
@adam-be

adam-be Apr 27, 2016

Member

If sender is not represented in localDescription

We don't say what "represented in a description" actually means. We could express this as if the RTCRtpTransceiver, which sender belongs to, is not yet associated with a media description...". That language is defined in JSEP.

Member

adam-be commented Apr 27, 2016

If sender is not represented in localDescription

We don't say what "represented in a description" actually means. We could express this as if the RTCRtpTransceiver, which sender belongs to, is not yet associated with a media description...". That language is defined in JSEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment