Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fob on RTCRtpEncodingParameters to turn on and off sending CN / DTX #644

Closed
fluffy opened this issue May 13, 2016 · 5 comments
Closed

Fob on RTCRtpEncodingParameters to turn on and off sending CN / DTX #644

fluffy opened this issue May 13, 2016 · 5 comments
Assignees

Comments

@fluffy
Copy link
Contributor

fluffy commented May 13, 2016

In the case where SDP negotiated CN allowed int he envelope, folks still want a FOB to turn on and off sending the RTP for it. (Relates to JSEP issue 202 and 233 )

@alvestrand
Copy link
Contributor

Hm. Doesn't look like an appropriate RTPSender surface. More like an encoding parameter, or even an audio track thingy.

But sure, people do ask for it.

@alvestrand
Copy link
Contributor

Seems like multiple people want this. Encoding parameter "feels" right.
Proposal needed.

aboba added a commit that referenced this issue May 26, 2016
@aboba aboba changed the title Fob on RTPSender to turn on and off sending CN / DTX Fob on RTCRtpEncodingParameters to turn on and off sending CN / DTX May 26, 2016
@aboba
Copy link
Contributor

aboba commented May 28, 2016

In the meeting today, it was pointed out that it is possible to turn CN on/off by adding/removing the CN codec from parameters.codecs[] and calling setParameters(). However, this does not work for DTX, because in WebRTC 1.0 (unlike in ORTC) there is no useDtx parameter than be set for a codec such as Opus.

So it occurs to me that an alternative way of addressing this need would be to add such an Opus parameter.

@juberti
Copy link
Contributor

juberti commented Jun 28, 2016

Having the CN codec and the FMTP param just means that DTX is possible, not that it is active. Same for the use of FEC (i.e., with negotiation of FEC 'codecs').

I think we want RtpEncodingParameters.vad or some such, similar to RtpEncodingParameters.fec.

@alvestrand
Copy link
Contributor

Closed by #734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants