Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trickled candidates may be added to the wrong session description #811

Closed
pthatcherg opened this issue Sep 22, 2016 · 2 comments
Closed

Comments

@pthatcherg
Copy link
Contributor

pthatcherg commented Sep 22, 2016

Currently, addIceCandidate adds a candidate to the pending remote description if there is one, and the current remote description otherwise. But if the remote peer has started an ICE restart and not yet received the answer from the local peer, the remote peer may trickle candidates for both session descriptions at the same time. The choice of which session description to apply it to must be done using the ufrag, otherwise candidates for the old (current) description will be wrongly added to the new (pending) description.

This is similar to issues #760, #757, and #726.

@taylor-b
Copy link
Contributor

taylor-b commented Nov 3, 2016

This seems identical to issue #726. I'd suggest closing it to reduce confusion.

@alvestrand
Copy link
Contributor

Closing as duplicate of #726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants