Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge juberti:master to doohickey branch #18

Merged
merged 5 commits into from Nov 1, 2014

Conversation

@juberti
Copy link
Contributor

commented Oct 31, 2014

Same as #3, just on the branch.

@@ -118,7 +118,7 @@
<dfn>Constraints</dfn>, and <dfn>Consumer</dfn> are defined in
[[!GETUSERMEDIA]].</p>
</section>

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

new trailing whitespace, for which I will not apologize for removing later

@@ -2075,6 +1791,314 @@
</section>

<section>
<h2>RTP media API</h2>

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

Capital M

@@ -2075,6 +1791,314 @@
</section>

<section>
<h2>RTP media API</h2>

<p>The RTP media API lets a web application send and receive MediaStreamTracks

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

<code>MediaStreamTrack</code>s, and similar throughout (tedious, ain't it?)

<h2>RTP media API</h2>

<p>The RTP media API lets a web application send and receive MediaStreamTracks
over a peer-to-peer connection. Tracks, when added to a PeerConnection, result in

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

RTCPeerConnection

is contained in the specified MediaStreams.</p>

<p>When the <dfn id="dom-peerconnection-addtrack"><code title=
"">addTrack()</code></dfn> method is invoked, the user agent MUST

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

s/ title=""// and this requires that you "queue a task" (as discussed)

defined and the order does not have to stable between calls.</p>
</dd>

<dt>RTCRtpSender addTrack (MediaStreamTrack track, MediaStream... streams)</dt>

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

Promise<RTCRtpSender> addTrack(...) ...

</ol>
</dd>

<dt>void removeTrack (RTCRtpSender sender)</dt>

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

For the purposes of symmetry, I think that we have to make this async too. That suggests a Promise-based API, but only for symmetry reasons.

does not wait for a given media track to be accepted or rejected via
SDP negotiation.</dd>

</dl>

This comment has been minimized.

Copy link
@martinthomson

martinthomson Nov 1, 2014

Member

outdent 4; or maybe just run tidy

fluffy added a commit that referenced this pull request Nov 1, 2014
Merge pull request #18 from juberti/master
Merge juberti:master to doohickey branch

@fluffy fluffy merged commit 18e893f into w3c:doohickey Nov 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.