Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTCRtpParameters, RTCRtpSender.getParameters, and RTCRtpSender.se… #234

Merged
merged 1 commit into from Jun 18, 2015

Conversation

Projects
None yet
3 participants
@pthatcherg
Copy link
Contributor

commented May 28, 2015

…tParameters.

@fluffy

This comment has been minimized.

Copy link
Contributor

commented May 29, 2015

I think we need to have a bunch of list discussion about this first. I would much rather do this as part of 1.1 not 1.0. The ORTC work has shown that we need to think carefully about this. We need to figure out how we are going to represent the encodings before we start adding API for it.

@pthatcherg

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2015

In this PR, I have only included the things that have had a lot of list
discussion, and which WG chairs specifically asked me to make a PR.

For example, there has been lots of discussion, and I believe consensus
(except for one WG member) on RtpParameters, getParameters, and
setParameters. That goes all the way back to TPAC 2014. The only reason I
didn't write a PR months ago for this if that RtpSenders only landed
recently.

Similarly, there has been lots of discussion and I believe rough consensus
on having a .active and a .priority, so I have included both.

It sounds to me like the only big issue remaining, and the one you
explicitly mention, is whether to have a sequence of encoding parameters or
not. In 1.0, it would only allow a single value anyway (no simulcast), so
it's not much different, except that it would allow future expansion to
support multiple encodings.

We've discussed that on the list before also. But I'd be glad to continue
that discussion. That's probably part of why the chairs asked me to make a
PR: to clarify what details we have left to discuss.
On May 29, 2015 8:08 AM, "Cullen Jennings" notifications@github.com wrote:

I think we need to have a bunch of list discussion about this first. I
would much rather do this as part of 1.1 not 1.0. The ORTC work has shown
that we need to think carefully about this. We need to figure out how we
are going to represent the encodings before we start adding API for it.


Reply to this email directly or view it on GitHub
#234 (comment).

alvestrand added a commit that referenced this pull request Jun 18, 2015

Merge pull request #234 from pthatcherg/set-parameters
Add RTCRtpParameters, RTCRtpSender.getParameters, and RTCRtpSender.se…

@alvestrand alvestrand merged commit 9322682 into w3c:master Jun 18, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@alvestrand

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2015

The chairs conclude that this approach has the consensus.

@pthatcherg pthatcherg deleted the pthatcherg:set-parameters branch Jun 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.