Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wpt tests to new directory #8

Closed
alvestrand opened this issue Jan 16, 2020 · 11 comments
Closed

Move wpt tests to new directory #8

alvestrand opened this issue Jan 16, 2020 · 11 comments
Labels
Test needed

Comments

@alvestrand
Copy link
Contributor

By the principles of wpt test naming, tests that reference "priority" should now be in a new webrtc-dscp-exp directory.

(which brings to mind: should we rename this spec "webrtc-priority"?)
@foolip
Copy link
Member

foolip commented Jan 17, 2020

I came here trying to deal with web-platform-tests/wpt#21223.

What does the "exp" in the shortname mean? If you are going to rename the spec, it'd be great if that happens soon, as renames need to be handled manually in reffy-reports and wpt.

@dontcallmedom
Copy link
Member

dontcallmedom commented Jan 17, 2020 •
edited

exp was for experimentation I believe. I took the action yesterday to rename it to webrtc-priority. I'm happy to do that now if this is a good time wrt reffy/wpt - in other words, I'll do it as soon as I see a green light from you

@foolip
Copy link
Member

foolip commented Jan 17, 2020

Now would be a good time, since I'd like to add a new directory in wpt, and then matching the spec name. Green light assuming @alvestrand also approves.

@dontcallmedom
Copy link
Member

name updated @foolip

@foolip
Copy link
Member

foolip commented Jan 17, 2020

Thanks @dontcallmedom! What will happen to https://www.w3.org/TR/webrtc-dscp/? That's what's listed in Reffy but can a TR name change? It's bit of a nuisance when TR name and GitHub repo name don't match...

@dontcallmedom
Copy link
Member

I plan to have the shortname updated (to webrtc-priority as well), but that will require a bit more time (hopefully sometimes next week)

@foolip
Copy link
Member

foolip commented Jan 17, 2020

Alright, good thing it's not set in stone :) Can you ping me or @tidoust when it's updated so we can update the URL in Reffy?

@dontcallmedom
Copy link
Member

The new TR URL is out @foolip https://www.w3.org/TR/webrtc-priority

tidoust added a commit to w3c/reffy that referenced this issue Jan 27, 2020
@tidoust
Update URL of WebRTC Priority Control API
7cc8076 
Shortname changed, see:
w3c/webrtc-priority#8 (comment)

Notes:
- The IDL extract will now be `webrtc-priority.idl` and not `webrtc-dscp.idl`.
- The previous shortname has become an alias from a W3C API perspective which
made Reffy fail (the W3C API does not yet handle aliases).
@tidoust tidoust mentioned this issue Jan 27, 2020
Merged
tidoust added a commit to w3c/reffy that referenced this issue Jan 27, 2020
@tidoust
Update URL of WebRTC Priority Control API (#235)
fcd764b 
Shortname changed, see:
w3c/webrtc-priority#8 (comment)

Notes:
- The IDL extract will now be `webrtc-priority.idl` and not `webrtc-dscp.idl`.
- The previous shortname has become an alias from a W3C API perspective which
made Reffy fail (the W3C API does not yet handle aliases).
@foolip
Copy link
Member

foolip commented Jan 28, 2020

Thanks @dontcallmedom! The rename has reached WPT: web-platform-tests/wpt#21442

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 14, 2020
@alvestrand @chromium-wpt-export-bot
Move all priority-related wpt/webrtc tests to webrtc-priority
6e2785e 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 14, 2020
@alvestrand @chromium-wpt-export-bot
Move all priority-related wpt/webrtc tests to webrtc-priority
cf9b48f 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 14, 2020
@alvestrand @chromium-wpt-export-bot
Move all priority-related wpt/webrtc tests to webrtc-priority
c06b8be 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 14, 2020
@alvestrand @chromium-wpt-export-bot
Move all priority-related wpt/webrtc tests to webrtc-priority
da71b38 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}
@alvestrand
Copy link
Contributor Author

The existing tests are now moved (extracted from the corresponding wpt/webrtc tests).

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 26, 2020
@alvestrand @moz-wptsync-bot
Bug 1637979 [wpt PR 23601] - Move all priority-related wpt/webrtc tes…
77953ac 
…ts to webrtc-priority, a=testonly

Automatic update from web-platform-tests
Move all priority-related wpt/webrtc tests to webrtc-priority

This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}

--

wpt-commits: da71b38ca8639d270e59b07fe65b0fecd6944a4a
wpt-pr: 23601
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 26, 2020
@alvestrand @moz-wptsync-bot
Bug 1637979 [wpt PR 23601] - Move all priority-related wpt/webrtc tes…
0b53f76 
…ts to webrtc-priority, a=testonly

Automatic update from web-platform-tests
Move all priority-related wpt/webrtc tests to webrtc-priority

This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}

--

wpt-commits: da71b38ca8639d270e59b07fe65b0fecd6944a4a
wpt-pr: 23601
@alvestrand
Copy link
Contributor Author

Moved as https://chromium-review.googlesource.com/c/chromium/src/+/2201757 (May 14 2020)

mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@alvestrand
Move all priority-related wpt/webrtc tests to webrtc-priority
10ee9e5 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#768834}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 863de46d81647e04549b7ccb7159f79f10bfd03b
ns-rsilva pushed a commit to ns-rsilva/chromium that referenced this issue Apr 25, 2024
@alvestrand
Move all priority-related wpt/webrtc tests to webrtc-priority
d1f4f04 
This aligns tests with a new document split.

Bug: w3c/webrtc-priority#8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}

Former-commit-id: 863de46d81647e04549b7ccb7159f79f10bfd03b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dontcallmedom @alvestrand @foolip