Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of a unreliable WebSocket-like API on top of QuicTransport #107

Merged
merged 7 commits into from Mar 13, 2019

Conversation

pthatcherg
Copy link
Collaborator

And also a fake QuicTransport loopback object.

Not sure if everything works, but I tested many things and most seems to work.

Might be useful as proof that a high-level API on top of a low-level API can work pretty easily.

@shampson
Copy link
Collaborator

Note to self - read through this then it should be ready to submit.

@pthatcherg
Copy link
Collaborator Author

Note from editor's meeting: waiting for at least one person to read this

@shampson
Copy link
Collaborator

Hey @pthatcherg, I went ahead and uploaded changes here. The main things are:

  • Updated datagrams API (promise based & added readyToSendDatagram)
  • Added more extensive testing of the fake transport and cleaned up the tests
  • Fixes to the fake quic transport
  • Fixed bugs as I found them
  • Cleaned up code (semicolons and misc)

Might be worth looking over things again, but this is now probably in a good enough state to merge.

@shampson
Copy link
Collaborator

Referencing this to issue 22

@aboba aboba merged commit 3d516b2 into master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants