Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do about onstatsended? #480

Closed
henbos opened this issue Aug 29, 2019 · 8 comments · Fixed by #497
Closed

What should we do about onstatsended? #480

henbos opened this issue Aug 29, 2019 · 8 comments · Fixed by #497

Comments

@henbos
Copy link
Collaborator

henbos commented Aug 29, 2019

Now that there is little point to having track/sender/receiver stats dictionaries around because all their members are made obsolete (#479), it seems that the only use case for them are having objects that would trigger onstatsended.

So what is the use case for onstatsended? Well, it's nice to know if replaceTrack() was called so that you can correlate stats changing with that point in time.

I think we can do better and not mandate people implement track attachment stats anymore. So what do we do about onstatsended?

@henbos henbos self-assigned this Aug 29, 2019
@henbos
Copy link
Collaborator Author

henbos commented Aug 29, 2019

@vr000m

@vr000m
Copy link
Contributor

vr000m commented Sep 16, 2019

We removed 'deleted' in #356 and #462 (leaving it here if earlier changes are impacted.)

@henbos
Copy link
Collaborator Author

henbos commented Sep 19, 2019

TPAC decision: Remove "onstatsended" and file a separate issue for "onstatsevent" or "onreplacetrack" or what else to do.

@henbos
Copy link
Collaborator Author

henbos commented Sep 22, 2019

Related TPAC decision: Remove "track" stats

@vr000m
Copy link
Contributor

vr000m commented Oct 2, 2019

@pallab-gain @karthikbr82 @lennart-csio this may affect our implementation and use-cases, Please take a look and put together a proposal for alternate solutions (atm it seems to be about exposing an event on webrtc-pc)

@henbos
Copy link
Collaborator Author

henbos commented Oct 31, 2019

onstatsended have now been removed from webrtc-pc: w3c/webrtc-pc#2305

@aboba
Copy link
Contributor

aboba commented Nov 14, 2019

@henbos Can we close this issue?

@henbos
Copy link
Collaborator Author

henbos commented Nov 15, 2019

I think so, we know the path forward for now based on TPAC and suggestions for alternative events can be addressed separately

@henbos henbos closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants