-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note controlling exposure of remote candidate addresses #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to fix the "note" thing, for process reasons. Should say "what do I do instead".
Uploaded related WPT test PR at web-platform-tests/wpt#13922 |
Written in terms of 'undefined' |
@youennf ping? |
@alvestrand, thanks for the ping. Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This satisfies my concern. Thank you!
LGTM |
this was renamed in w3c/webrtc-pc#1913 and w3c/webrtc-stats#381 Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-address BUG=chromium:968203 Change-Id: I5e23e27c68c766188b81ed244e327c1cfb6b1a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780267 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#866151} GitOrigin-RevId: 5ceb883a824c4ed7f37f85569ec38b213ea2562a
No description provided.