Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how RTX works and adds the rtxSsrc stat #554

Merged
merged 1 commit into from Mar 18, 2020
Merged

Clarify how RTX works and adds the rtxSsrc stat #554

merged 1 commit into from Mar 18, 2020

Conversation

henbos
Copy link
Collaborator

@henbos henbos commented Mar 18, 2020

Fixes #553.

@henbos henbos requested a review from vr000m March 18, 2020 08:15
@henbos
Copy link
Collaborator Author

henbos commented Mar 18, 2020

I think this is what we want the spec to say. It's confusing if bytes and retransmissions are put in separate counters and have to manually be added together to get something sensible - it matters little whether they are sent on ssrc or rtxSsrc.

However, the fact that bytesSent includes retransmissions means that "Total number of RTP packets sent for this <a>SSRC</a>" is actually referring to the bytes sent of both the {{RTCRtpStreamStats/ssrc}} and the {{RTCOutboundRtpStreamStats/rtxSsrc}}.

This matches current implementation though.

@henbos
Copy link
Collaborator Author

henbos commented Mar 18, 2020

This PR was reviewed by ilnik@webrtc.org (Google developer) who knows the RTX code, he says LGTM.

alvestrand
alvestrand approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, according to my understanding of how RTX works.

@henbos
Copy link
Collaborator Author

henbos commented Mar 18, 2020

@vr000m Can you merge this?

vr000m
vr000m approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@vr000m vr000m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vr000m vr000m merged commit 1be3dbd into w3c:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vr000m vr000m vr000m approved these changes

@alvestrand alvestrand alvestrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard getStats() and RTX streams
3 participants
@henbos @vr000m @alvestrand