New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify "writeDatagrams" in more detail #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jan-ivar , can you tell me the meaning of the label "Editors can integrate"? |
@yutakahirano Sorry, I didn't see your message sooner! It's a "please merge the PR at your convenience (after addressing any nits)" label. It means the PR is good to go, but some detail or nit prevented us from merging it. In this case there were conflicts that needed resolving. Let me see if I can resolve them. |
Actually, I also promised to look over this one. Let me do that quickly as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The back-pressure parts LGTM! Some nits, and threading concerns, but I'm happy to open a new issue on the latter.
index.bs
Outdated
The user agent SHOULD run [=sendDatagrams=] for any {{WebTransport}} object whose | ||
{{[[WebTransportState]]}} is `"connected"` as soon as reasonably possbile whenever | ||
the algorithm can make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this on the JS thread seems wrong. I have some concerns about threading in general here, but I'll open a new issue so we can iterate and merge this (with my other nits).
sendDatagrams
that can be called at any time.writeDatagrams
.Related to #179 and #187. This change adds internal slots but doesn't change the public interface.
Preview | Diff