Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Parsing: should drop line:100,invalid setting #336
I think we should validate
(Noticed this when looking at @BenjaminSchaaf's revamp of parsing tests.)
The normal parsing of settings in WebVTT is to drop it on the floor if there is a syntax error. This case does not do that.
It matters because it gives unexpected result and makes it difficult to start using new alignments in the transition period when some implementations support the new value and some do not.
Let's say browsers implement what the spec requires now. Then we add a new alignment "foo". Then the author uses it like this, providing a fallback for legacy UAs:
The expectation is that legacy UAs use the first setting and ignore