New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wide Review Comment 2017: formatting issues #385
Comments
The yellow highlight colour on srclang in Example 19 is to highlight the srclang attribute use in that example. I think it's useful. The text above it says: The applicable language for the list of WebVTT Node Objects can be set by the srclang attribute in HTML. So it makes sense to mark the srclang attribute specifically. I'll not change this in the patch, if that's ok with you. |
@silviapfeiffer Oh I see, that wasn't obvious to me. I see what you mean, but it does still seem odd that it's the only fragment of an example that warrants this yellow styling. |
Resolution: remove the yellow |
Highlight was removed and patch updated, please review. |
Patch landed, all issues were addressed. I think we need issue submitter comment. |
@nigelmegitt are you ok with the resolution of this issue with the patch in #396 ? |
For posterity: #396 (review) |
Copy/paste from https://lists.w3.org/Archives/Public/public-tt/2017Sep/0080.html - raising as an issue for tracking/disposition purposes.
There seem to be some formatting oddities when I view the specification on Firefox or Chrome – in section 3.1 there's an algorithm for calculating the computed line, whose outline box might be helpful but overlaps the bullet numbers on the left.
The diagram at the bottom of section 3.2 seems to truncate the word "Video viewport".
Some text has a yellow highlight colour without explanation, e.g. In Example 19.
The text was updated successfully, but these errors were encountered: