Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all of HTML's character references #253

Merged
merged 1 commit into from Nov 16, 2015

Conversation

@zcorpan
Copy link
Member

commented Nov 12, 2015

This hooks in to HTML's 'consume a character reference' for parsing,
and 'character references' for the syntax. All forms of charrefs
that HTML supports are supported, including missing semicolon.
(But missing semicolon is not valid, nor is a lone ampersand.)

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=23867.
Ref. #198.

@silviapfeiffer

This comment has been minimized.

Copy link
Member

commented Nov 15, 2015

WFM

@zcorpan

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2015

@annevk can I ask for a sanity check from HTML's point of view?

@annevk

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

I would have preferred a truly reusable algorithm rather than this monkey patch way, but I guess it's okay.

@zcorpan

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2015

OK, we can clean it up when we have implementation experience suggesting this approach is working. Thanks!

This hooks in to HTML's 'consume a character reference' for parsing,
and 'character references' for the syntax. All forms of charrefs
that HTML supports are supported, including missing semicolon.
(But missing semicolon is not valid, nor is a lone ampersand.)

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=23867.
Ref. #198.
@zcorpan zcorpan force-pushed the support-html-charrefs branch from efbfd7e to ead885d Nov 16, 2015
@zcorpan zcorpan merged commit ead885d into gh-pages Nov 16, 2015
@zcorpan zcorpan deleted the support-html-charrefs branch Nov 16, 2015
zcorpan added a commit that referenced this pull request Nov 16, 2015
@zcorpan zcorpan referenced this pull request Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.