Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the parsing rule to set the cue's identifier. #312

Merged
merged 1 commit into from Jul 15, 2016

Conversation

alastor0325
Copy link
Collaborator

According to #310, the parser doesn't set the cue identifier to anything but the empty string.
The fix is to set the cue identifier to buffer on cue creation.

@zcorpan, could you help me review this patch?
Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jul 6, 2016

Change looks good, but you should edit index.bs instead.

You also should do something to make the ipr checker happy. cc @plehegar

@alastor0325
Copy link
Collaborator Author

Hi, @zcorpan,
Could you help me review the patch again?
In addition, the ipr checker said that I'm not in the right group, which group I should join in?
Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jul 7, 2016

Looks good!

https://www.w3.org/AudioVideo/TT/#join

@alastor0325
Copy link
Collaborator Author

hi, @zcorpan,
sorry for this stupid question,
I have already joined that group, and what's the next steps to make my commit to pass the checker?
Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jul 11, 2016

Great! Try force-pushing an amended commit to rerun the checker.

@alastor0325
Copy link
Collaborator Author

Hi, @zcorpan,
Do I still need to do any modification? or we can merge this commit?
Thanks :)

@zcorpan zcorpan merged commit d646b97 into w3c:gh-pages Jul 15, 2016
zcorpan added a commit that referenced this pull request Jul 15, 2016
@zcorpan
Copy link
Member

zcorpan commented Jul 15, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants