Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues #94 and #21 #95

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Fixes for issues #94 and #21 #95

merged 3 commits into from
Apr 17, 2020

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented Apr 2, 2020

I am addressing the issues #21 and #94


Preview | Diff

@egekorkan egekorkan changed the title WIP: Fixes for issues #94 and #21 Fixes for issues #94 and #21 Apr 2, 2020
@egekorkan egekorkan requested a review from mjkoster April 2, 2020 23:13
@egekorkan
Copy link
Contributor Author

We can bump the OCF version to 2.0

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@egekorkan
Copy link
Contributor Author

I have incorporated @zolkis comments

Copy link
Contributor

@mjkoster mjkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link

@zolkis zolkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@egekorkan egekorkan merged commit 86ed009 into master Apr 17, 2020
@egekorkan egekorkan deleted the ege-fixes branch March 3, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants