Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian subtitles #147

Merged
merged 5 commits into from Mar 17, 2021
Merged

Add Italian subtitles #147

merged 5 commits into from Mar 17, 2021

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Mar 9, 2021

I used the same timings, they should be fine. I tested with windows video player and they look ok. Unfortunately, in some places, they are barely visible cause the video player displays the captions in white.

Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some minor typos ... but I might be wrong

@relu91
Copy link
Member Author

relu91 commented Mar 9, 2021

Thank you, Daniel! sorry but I couldn't make work a spell checker in my code editor for Italian 🤣

Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielpeintner danielpeintner merged commit a4d0de8 into w3c:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants