New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow-top-navigation-by-user-activation #154

Closed
domenic opened this Issue Feb 23, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@domenic
Copy link
Member

domenic commented Feb 23, 2017

Hello TAG!

I'm requesting a TAG review of:

Further details (optional):

  • Relevant time constraints or deadlines: Chrome is hoping to ship this in a branch that will branch March 2, so any feedback before then would be helpful.
  • I have read and filled out the Self-Review Questionnare on Security and Privacy. Although this touches on related areas, it's largely a strengthening of the isolation that was present before (with allow-top-navigation), and none of the questions seem directly relevant.
  • I have reviewed the TAG's API Design Principles

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review (preferably comment on whatwg/html#2292)
  • leave review feedback as a comment in this issue and @-notify [github usernames]

@cynthia cynthia self-assigned this Mar 14, 2017

@cynthia

This comment has been minimized.

Copy link
Member

cynthia commented Mar 15, 2017

First of all, apologies for the delay - I see that we completely missed the requested deadline.

I'm pretty happy with this - it seems like the ground work for defining a trusted event / user interaction has made good progress, so I don't think we have any objections on moving this forward.

As long as whatwg/html#1903 gets properly followed up on, LGTM. I've subscribed to that issue, so that nit shouldn't block this. Thanks a lot!

@cynthia cynthia closed this Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment