-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAG Review Request: queueMicrotask #294
Comments
@fergald The explainer Google Doc link seems to be locked, would it be possible to make it world open? |
@dbaron wonders if the name "microtask" is the best name to expose to developers--yes its the spec-term, but may not be the best name :-) |
Hmm, any other suggestions? |
@cynthia Sorry about that. Done. |
So one thought is that |
Hey @fergald: thanks for filing a review request! Some questions:
|
I'm working on adding some examples to the spec in my spare time; I have them about half-completed. The argument against
Not aware of many other unavailable timings, personally... maybe the different task sources the browser uses for task-queuing? |
Re: Arguments - I've updated the explainer to include Domenic's justifications. Re: example for using this vs alternatives - I've rewritten the motivation section. There are 2 things I could be explaining:
Previously the doc was a mix of both. It's now focused on the latter (but includes a link to another article that explains more about the former). Viewed in that way, there are no reasonable alternatives, if you want to queue a microtask you should call If you feel strongly that the doc needs to explain more about what a microtask is and when it's the right choice, I can add that but it seems secondary. Re: other timings that should be exposed - I defer to others on that. @dbaron Cancellation seems reasonable to me. @domenic any opinions on that? |
The last argument about layering is pretty compelling to me. Do we know for a fact that implementations don't elide |
I'm like 95% sure without testing/asking anyone. There are so many observable side effects to the promise existing (especially if the queued code returns anything or throws an exception) that it'd take some serious engine heroics to elide the result, and even if they did you could easily fall off of the garden path and accidentally force it to be allocated again. |
Fergal and I discussed this offline. We were initially agnostic, but came around eventually to thinking that cancelation isn't desirable, at least for now. The main reasons are:
|
Pull request for examples up: whatwg/html#3873 |
Your conclusion about cancellation seems fine with me. |
I'm also satisfied with the conclusions. I only have a couple of minor bits of feedback:
|
@travisleithead Thanks for comments. Removed the custom elements line and migrated the doc to https://fergald.github.io/docs/explainers/queueMicrotask.html |
@fergald Thanks! |
Hello TAG!
I'm requesting a TAG review of:
Further details (optional):
We'd prefer the TAG provide feedback as (please select one):
The text was updated successfully, but these errors were encountered: