Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Custom Highlight API Module Level 1 #584

Closed
1 task done
frivoal opened this issue Dec 8, 2020 · 5 comments
Closed
1 task done

CSS Custom Highlight API Module Level 1 #584

frivoal opened this issue Dec 8, 2020 · 5 comments

Comments

@frivoal
Copy link

@frivoal frivoal commented Dec 8, 2020

你好 TAG! 吃饭了吗?

I'm requesting a TAG review of CSS Custom Highlight API Module Level 1, which was recently published as a FPWD.

The Custom Highlight API extends the concept of highlight pseudo-elements (see CSS Pseudo-Elements 4 §3 Highlight Pseudo-elements) by providing a way for web developers to style the text of arbitrary Range objects, rather than being limited to the user agent defined ::selection, ::spelling-error, and ::grammar-error. This is useful in a variety of scenarios, including editing frameworks that wish to implement their own selection, find-on-page over virtualized documents, multiple selection to represent online collaboration, or spellchecking frameworks. The Custom Highlight API provides a programmatic way of adding and removing highlights that do not affect the underlying DOM structure, but instead applies styles to text based on range objects, accessed via the ::highlight() pseudo element.

Further details:

  • I have reviewed the TAG's API Design Principles
  • Relevant time constraints or deadlines: Nothing in particular
  • The group where the work on this specification is currently being done: CSSWG
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): CSSWG
  • Major unresolved issues with or opposition to this specification: No known opposition, event part still missing
  • This work is being funded by: Bloomberg, Microsoft, Apple

We'd prefer the TAG provide feedback as 🐛 open issues in our GitHub repo for each point of feedback

@alice alice self-assigned this Jan 6, 2021
@atanassov atanassov self-assigned this Jan 6, 2021
@torgo torgo assigned hober and unassigned atanassov Jan 6, 2021
@torgo torgo added this to the 2021-01-11-week milestone Jan 6, 2021
@LeaVerou
Copy link
Member

@LeaVerou LeaVerou commented Jan 11, 2021

To everyone else reviewing: The differences between the explainer and the actual spec are at this point very substantial. I would suggest that people review the spec's own intro section instead of the explainer to get an overview of the current status.

Yes, it is mentioned above in passing, but thought I'd highlight it (pun intended 😁) in case others also start from the explainer by force of habit despite @frivoal's comment, and then realize that all their comments do not apply to the current spec anymore.

Loading

@florian
Copy link

@florian florian commented Jan 12, 2021

Lea, I'm pretty sure you meant to @ mention some other Florian.

Loading

@LeaVerou LeaVerou self-assigned this Jan 18, 2021
@LeaVerou
Copy link
Member

@LeaVerou LeaVerou commented Jan 26, 2021

@hober and I discussed this today in our VF2F. We noticed that HighlightsRegister is a setlike, but throws when a Highlight object with an existing registered name, which indicates that perhaps maplike would have been more appropriate? It's not ideal developer experience if developers need to iterate the entire data structure before registering their object, to check if an existing one of the same name exists. Maplike would also provide an easy way to get all ranges under a given name.

Loading

@frivoal
Copy link
Author

@frivoal frivoal commented Jan 31, 2021

Filed the above comment as w3c/csswg-drafts#5910

Loading

@plinss plinss changed the title Requesting a TAG review of CSS Custom Highlight API Module Level 1 CSS Custom Highlight API Module Level 1 Feb 14, 2021
@plinss plinss removed this from the 2021-01-11-week milestone Feb 14, 2021
@plinss plinss added this to the 2021-03-15-week milestone Feb 14, 2021
@plinss plinss removed this from the 2021-03-15-week milestone Mar 16, 2021
@plinss plinss added this to the 2021-03-29-week milestone Mar 16, 2021
@plinss plinss removed this from the 2021-03-29-week milestone Mar 30, 2021
@plinss plinss added this to the 2021-04-12-week milestone Mar 30, 2021
@plinss plinss removed this from the 2021-04-12-week milestone Apr 8, 2021
@plinss plinss added this to the 2021-04-19-week milestone Apr 8, 2021
@plinss plinss removed this from the 2021-04-19-week milestone Apr 26, 2021
@plinss plinss added this to the 2021-05-10-F2F-Arakeen milestone Apr 26, 2021
@LeaVerou
Copy link
Member

@LeaVerou LeaVerou commented May 11, 2021

@hober and I discussed this in a VF2F breakout today. We noticed that the issue we pointed out in our earlier review has now been fixed, so we're happy with its current state and will go ahead and close this. Feel free to open another review if there are substantial changes in the future.

Loading

@hober hober closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants