Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested file name and location for the File System Access API. #598

Closed
1 task done
mkruisselbrink opened this issue Jan 22, 2021 · 11 comments
Closed
1 task done
Assignees
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Topic: Filesystem Venue: WICG

Comments

@mkruisselbrink
Copy link

HIQaH! QaH! TAG!

I'm requesting a TAG review of suggested file name and location for the File System Access API.

When initially shipping the File System Access API we shipped a bare minimum API surface
for showing file and directory pickers. We're now proposing adding a couple of frequently
requested (and commonly supported in other file picker APIs) options to let websites
provide a couple more opportunities to influence the behavior of the file and directory pickers.
In particular we want to let websites give suggestions for the name and location of files and
directories that are being saved or loaded.

Further details:

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

@mkruisselbrink mkruisselbrink added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Jan 22, 2021
@kenchris kenchris self-assigned this Jan 22, 2021
@kenchris
Copy link

@torgo and I looked at this in our Virtual TAG F2F breakout.

Thank you for the great explainer and links to developer interest. The feature additions look very sensible to us.

@torgo
Copy link
Member

torgo commented Jan 26, 2021

I would like to see a bit more discussion in the explainer about why this does not present privacy issues for the end user? Reading between the lines, it seems to me that the web application would not gain additional information about the user's file system hierarchy - but for example could information about the existence of well-known starting locations be improperly exposed?

@torgo torgo added the privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. label Jan 26, 2021
@tomayac
Copy link

tomayac commented Jan 26, 2021

For the file name, this is something that <a download="readme.txt"> already enables.

For the well-known directories, these would indeed map to the by-default ones that operating systems commonly have. Here's an example from macOS (the app would not learn that my home directory is called tsteiner):

Screen Shot 2021-01-26 at 11 15 14

@torgo
Copy link
Member

torgo commented Jan 26, 2021

For the well-known directories, these would indeed map to the by-default ones that operating systems commonly have. Here's an example from macOS (the app would not learn that my home directory is called tsteiner):

Thanks for the quick reply @tomayac! Just to clarify : I understand that the home directory name would be kept private but would the app be able to confirm the existence of "Downloads" or "Movies" (or something else) through use of this API?

@tomayac
Copy link

tomayac commented Jan 26, 2021

It is a suggestion, so if, for whatever reason, the user has deleted, for example, their ~/Downloads folder (the default folder for downloads on macOS), the picker would just open at another location (implementation-specific), unobservable to the website.

@hemeryar
Copy link

We had a look today during the chrome security/privacy triage and it was looking good overall. There was no real concern for any of the suggestions apart from /home/ that felt a bit too close to root. Is there specific use cases you're thinking about for this one or should we maybe remove it from the well known list?

mkruisselbrink added a commit to WICG/file-system-access that referenced this issue Jan 26, 2021
Remove 'home' from well know directories to address w3ctag/design-reviews#598 (comment)
@mkruisselbrink
Copy link
Author

We didn't really have any specific use cases in mind for home, it just seemed like a nice to have one. But given your concerns, removing it from the well known list sounds good to me.

mkruisselbrink added a commit to WICG/file-system-access that referenced this issue Jan 26, 2021
Remove 'home' from well know directories to address w3ctag/design-reviews#598 (comment)
github-actions bot added a commit to WICG/file-system-access that referenced this issue Jan 26, 2021
Remove 'home' from well know directories to address w3ctag/design-reviews#598 (comment)

SHA: 7c644c5
Reason: push, by @mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yisibl
Copy link

yisibl commented Jan 28, 2021

Can the new design be recorded in the download list of the browser? (e.g. chrome://downloads/)

@mkruisselbrink
Copy link
Author

Can the new design be recorded in the download list of the browser? (e.g. chrome://downloads/)

No, I think that would have to be a separate feature (I mean, technically nothing it stopping browsers from showing files picked via showSaveFilePicker in their "downloads" list, but not sure when/why it would make sense to do so).

@plinss plinss added this to the 2021-03-08-week milestone Feb 17, 2021
@torgo torgo added the Progress: propose closing we think it should be closed but are waiting on some feedback or consensus label Mar 9, 2021
@kenchris
Copy link

kenchris commented Mar 9, 2021

We don't have any further comments, so this looks good to us!

@torgo torgo closed this as completed Mar 10, 2021
@torgo torgo added the Resolution: satisfied The TAG is satisfied with this design label Mar 10, 2021
@Roaders
Copy link

Roaders commented Mar 25, 2021

Can the new design be recorded in the download list of the browser? (e.g. chrome://downloads/)

No, I think that would have to be a separate feature (I mean, technically nothing it stopping browsers from showing files picked via showSaveFilePicker in their "downloads" list, but not sure when/why it would make sense to do so).

In my use case (downloading reports in either pdf or spreadsheet format) it would be very useful to show the downloaded file in the footer of the browser as most of the time a user will want to immediately open the file after it has been downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Topic: Filesystem Venue: WICG
Projects
None yet
Development

No branches or pull requests

8 participants