Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-expanding details elements #677

Closed
1 task done
josepharhar opened this issue Sep 16, 2021 · 6 comments
Closed
1 task done

Auto-expanding details elements #677

josepharhar opened this issue Sep 16, 2021 · 6 comments
Assignees
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. Progress: review complete Resolution: satisfied The TAG is satisfied with this design

Comments

@josepharhar
Copy link

josepharhar commented Sep 16, 2021

Ya ya yawm TAG!

I'm requesting a TAG review of Auto-expanding details elements.

Summary:
Today, closed details elements aren't searchable by find-in-page or ScrollToTextFragment, and if a user wants to search in them with find-in-page they would have to manually open every details element in the page before beginning their search.
This feature makes closed details elements searchable and automatically expands them when the browser tries to scroll to content inside of them for find-in-page, ScrollToTextFragment, and element fragment navigation.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: none
  • The group where the work on this specification is currently being done: WICG
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): WHATWG
  • Major unresolved issues with or opposition to this specification: none
  • This work is being funded by: Google

We'd prefer the TAG provide feedback as (please delete all but the desired option):

💬 leave review feedback as a comment in this issue and @-notify [github usernames]

@LeaVerou LeaVerou self-assigned this Sep 17, 2021
@torgo torgo added this to the 2021-09-27-week milestone Sep 22, 2021
@chrishtr chrishtr added the chromium-high-priority Something that the Chromium team would like the TAG to prioritise label Sep 23, 2021
@josepharhar
Copy link
Author

There is some useful discussion here: mozilla/standards-positions#578

@torgo
Copy link
Member

torgo commented Oct 12, 2021

Hi @josepharhar. Regarding the security & privacy questionnaire - you've noted a privacy venerability and a potential mitigation. (Great!) Is this documented anywhere in the spec itself? We are generally supportive - we just want to bottom out the potential privacy issue that you've documented. Also adding privacy-tracker label to bring it to the attention of Privacy Interest Group.

@torgo torgo added the privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. label Oct 12, 2021
@josepharhar
Copy link
Author

you've noted a privacy venerability and a potential mitigation. (Great!) Is this documented anywhere in the spec itself?

No, I didn't include this in the spec

@slightlyoff
Copy link
Member

hey @josepharhar, per the Intent thread, it'd be great to see a non-normative note in the spec flagging that this is a potential concern, perhaps in your privacy and security considerations section?

Thanks.

josepharhar added a commit to josepharhar/html that referenced this issue Oct 15, 2021
josepharhar added a commit to josepharhar/html that referenced this issue Oct 15, 2021
@josepharhar
Copy link
Author

hey @josepharhar, per the Intent thread, it'd be great to see a non-normative note in the spec flagging that this is a potential concern, perhaps in your privacy and security considerations section?

I opened a PR to add a non-normative note here: whatwg/html#7229

@torgo
Copy link
Member

torgo commented Oct 18, 2021

Thanks @josepharhar and @slightlyoff - much appreciated. I think on that basis we're happy to close the review. We discussed this last week and we have no objections. Thanks for flying TAG.

@torgo torgo closed this as completed Oct 18, 2021
@torgo torgo added Resolution: satisfied The TAG is satisfied with this design Progress: review complete and removed Progress: in progress labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. Progress: review complete Resolution: satisfied The TAG is satisfied with this design
Projects
None yet
Development

No branches or pull requests

9 participants