-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigateEvent.sourceElement #867
Comments
Hi there @natechapin, @domenic, a quick request for clarification:
This is because the navigation events are always from same-origin sources, so the website could have tracked the source element itself if it so desired? |
Correct! |
Hi - Can you please author an explainer for this so that we can conduct the review? Thanks! ✨ |
What is wrong with the explainer linked in the OP? (Notice this is a single added property in a larger spec, so it's being done as an update to that spec's explainer.) |
You mean this? It’s missing nearly all the sections an explainer needs, described here. If it's too small a feature to meaningfully have an explainer, it may be too small to need TAG review. |
That explainer (full version at https://github.com/WICG/navigation-api/blob/b0286752a0a5a1babd782e4bc8e68e696538fd10/README.md) does have all the sections. It's true this addition is a small part of the overall navigation API. Perhaps it is too small to need TAG review; if that's the TAG's judgment, then please feel free to close :). |
As agreed on today's call. We agree it's too small to require a TAG review so we're going to close. |
こんにちは TAG-さん!
I'm requesting a TAG review of navigateEvent.sourceElement.
This is a small extension of the navigation API, which was previously reviewed in #605 and #717. The navigateEvent exposes many details about a navigation that has just begun, and we wish to add a
sourceElement
attribute: theElement
that initiated the navigation (if any).Further details:
sourceElement
.We'd prefer the TAG provide feedback as (please delete all but the desired option):
💬 leave review feedback as a comment in this issue and @-notify [@natechapin, @domenic]
The text was updated successfully, but these errors were encountered: