Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBrush follow-up 2 milestone 7 modification #1149

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Aug 29, 2022

Many developers are asking for the feature to test cross-contract calls in unit tests because it is hard to mock it each time and makes the testing much harder, forcing people to write integration tests with Redspot, Swanky, and Typechain-Polkadot.

We want to prioritize this task and deliver the trait refactoring in ink! later(Initially, we plan to implement an advanced testing framework in milestone eight it is why we can swap those tasks). Because it is a hot topic and after discussion in the issue and element channel, it is clear how it should be implemented=)

The scope of work is the same and also related to the ink! repository. Because it requires modification of the off-chain environment.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

#921

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

@alxs alxs self-assigned this Aug 30, 2022
Copy link
Contributor

@alxs alxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@alxs alxs added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. labels Aug 30, 2022
@Noc2 Noc2 requested a review from takahser September 6, 2022 12:32
@Noc2 Noc2 merged commit 841f851 into w3f:master Sep 6, 2022
@coreggon11 coreggon11 mentioned this pull request Oct 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants