Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slingshot and zkvm agreement #34

Closed
burdges opened this issue May 10, 2019 · 1 comment
Closed

slingshot and zkvm agreement #34

burdges opened this issue May 10, 2019 · 1 comment

Comments

@burdges
Copy link
Collaborator

burdges commented May 10, 2019

It'd be lovely to agree with slingshot's key tree derivation, but they do strange things like encourage intermediate derivations, and dropping chain codes, so doing so sounds awkward. https://github.com/stellar/slingshot/blob/main/keytree/keytree.md

We can however agree with their key serializations format by dropping out concerns about ed25519 private keys in #9 so that the same private and public keys work for both schnorrkel and zkvm.

I'm not so fond of their musig implementation in https://github.com/stellar/slingshot/tree/main/musig which seemingly does not enforce correct usage with session types, although it may enforce correct usage with runtime errors.

@burdges burdges changed the title slingshot agreement slingshot and zkvm agreement May 10, 2019
burdges added a commit that referenced this issue May 12, 2019
This should make it easier to interact with Ristretto crates like
slingshot.  See  #34  and  #9
@burdges
Copy link
Collaborator Author

burdges commented May 12, 2019

We cannot agree with their secret key serialization formats because the never serialize any seed for nonces. I'm unhappy doing that because I want both derandomization and randomized protections, so I'll close this now.

I did however make the default secret key serialization use the canonical bytes instead of the ed25519 compatible bit shifting, some anyone who wants compatibility with slingshot can just make up their own nonce seeds or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant