Skip to content

Commit

Permalink
Fixed navigation keys not working right after closing search bar
Browse files Browse the repository at this point in the history
- keys PageUp, PageDown, Space and arrows

closes QupZilla#530
  • Loading branch information
nowrep committed Aug 27, 2012
1 parent 1e5b7d9 commit 4f3c3cd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG
Expand Up @@ -11,11 +11,13 @@ Version 1.3.5
* Save x as ... actions will always show file dialog
* possibility to choose to use external download manager on every download
* remember last section in preferences
* much more tabs now fits into tabbar without overflowing into tab buttons
* smarter address bar completer will show better search results
* new User Agent manager lets you set User Agent per site
* new restore session page lets you choose which tabs you want to restore
* new scheme handler for file protocol allows browsing through directories
* new option to show loading progress in address bar
* new option to hide close button on tabs
* fixed visibility of navigation bar in fullscreen
* fixed bad position of add tab button when there is a lot of tabs
* fixed gui with RTL languages
Expand Down
2 changes: 1 addition & 1 deletion src/lib/history/history.cpp
Expand Up @@ -71,7 +71,7 @@ void History::addHistoryEntry(const QUrl &url, QString title)
if (url.scheme() == "qupzilla" || url.scheme() == "about" || url.isEmpty()) {
return;
}
if (title == "") {
if (title.isEmpty()) {
title = tr("No Named Page");
}

Expand Down
8 changes: 4 additions & 4 deletions src/lib/webview/searchtoolbar.cpp
Expand Up @@ -62,10 +62,10 @@ void SearchToolBar::focusSearchLine()

void SearchToolBar::hide()
{
searchText("");
p_QupZilla->weView()->setFocus();

AnimatedWidget::hide();

searchText(QString());
p_QupZilla->weView()->setFocus();
}

void SearchToolBar::findNext()
Expand Down Expand Up @@ -102,7 +102,7 @@ void SearchToolBar::highlightChanged()
view->findText(ui->lineEdit->text(), m_findFlags | QWebPage::HighlightAllOccurrences);
}
else {
view->findText("", QWebPage::HighlightAllOccurrences);
view->findText(QString(), QWebPage::HighlightAllOccurrences);
}
}

Expand Down

0 comments on commit 4f3c3cd

Please sign in to comment.