Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed issues with profile Photos and default skin #286

Merged
merged 2 commits into from May 4, 2012

Conversation

Projects
None yet
2 participants
Collaborator

laurenyew commented May 4, 2012

Fixed #270
Fixed #260
Fixed #268
Fixed default skin so that it is now the correct skin instead of ut skin
Fixed photos so now the profile photo is set by a query (static going to null is no longer a problem)
Fixed profilePhoto deletion (added in changing to default profile photo if deleting the profile photo)

laurenyew added some commits May 4, 2012

@laurenyew laurenyew Fixed #268. Now b3bob's skin is the correct default skin. c088f21
@laurenyew laurenyew Fixed #270 and Fixed #260. Added in changing to defaultprofilephoto f…
…or if you delete your profile photo. Added in use of photo query for default photo. Fixed error in changing or adding profile photos and gravatar (routes problem). Skins and changing the profile photo is now working.
a4fd133
Collaborator

amshali commented May 4, 2012

try setting the picture using gravatar:
I get the following exception.
Internal Server Error (500) for request GET /photos/setProfilePhoto

Execution exception (In /app/controllers/Photos.java around line 118)
IllegalArgumentException occured : id to load is required for loading

play.exceptions.JavaExecutionException: id to load is required for loading
at play.mvc.ActionInvoker.invoke(ActionInvoker.java:231)
at Invocation.HTTP Request(Play!)
Caused by: java.lang.IllegalArgumentException: id to load is required for loading
at org.hibernate.event.LoadEvent.(LoadEvent.java:89)
at org.hibernate.event.LoadEvent.(LoadEvent.java:61)
at org.hibernate.impl.SessionImpl.get(SessionImpl.java:1002)
at org.hibernate.impl.SessionImpl.get(SessionImpl.java:998)
at org.hibernate.ejb.AbstractEntityManagerImpl.find(AbstractEntityManagerImpl.java:614)
at org.hibernate.ejb.AbstractEntityManagerImpl.find(AbstractEntityManagerImpl.java:589)
at play.db.jpa.JPQL.findById(JPQL.java:36)
at models.Photo.findById(Photo.java)
at controllers.Photos.setProfilePhoto(Photos.java:118)
at play.mvc.ActionInvoker.invokeWithContinuation(ActionInvoker.java:548)
at play.mvc.ActionInvoker.invoke(ActionInvoker.java:502)
at play.mvc.ActionInvoker.invokeControllerMethod(ActionInvoker.java:478)
at play.mvc.ActionInvoker.invokeControllerMethod(ActionInvoker.java:473)
at play.mvc.ActionInvoker.invoke(ActionInvoker.java:161)

Collaborator

laurenyew commented May 4, 2012

Can you be more specific? I made a gravatar successfully.

Collaborator

laurenyew commented May 4, 2012

Try running play clean and play dependencies again. I had to change the routes file for that GET

@amshali amshali added a commit that referenced this pull request May 4, 2012

@amshali amshali Merge pull request #286 from laurenyew/master
Fixed issues with profile Photos and default skin
bff0524

@amshali amshali merged commit bff0524 into w7cook:master May 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment