Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R66] XMLRuleDAO select, find and exists operations only work on internal cache #64

Closed
bcarlin opened this issue Aug 3, 2020 · 1 comment · Fixed by #71
Closed

[R66] XMLRuleDAO select, find and exists operations only work on internal cache #64

bcarlin opened this issue Aug 3, 2020 · 1 comment · Fixed by #71
Labels
bug Something isn't working
Milestone

Comments

@bcarlin
Copy link
Member

bcarlin commented Aug 3, 2020

To avoid lookups on disk every time a Rule is selected, XMLRuleDAO has an internal cache, which is good.

However, select, find and exists operations only works on the internal cache (as opposed to XMLHostDAO which falls bach on disk search if nothing id found in the internal cache).

As the internal cache if only filled when getAll() is called, there are some situations where select, find and exists never find rules that do exists.
As a side effect, the file watcher is not working without database: SpooledDirectoryTransfer (and its execution tree) never runs XMLRuleDAO.getAll() durining its initialization, so the individual lookups for each spooldirectory's rule always fail.

@bcarlin bcarlin added the bug Something isn't working label Aug 3, 2020
fredericBregier added a commit to fredericBregier/Waarp-All that referenced this issue Aug 11, 2020
When client or server is loaded using no database, therefore using XMLDBDAO,
the rules were not loaded correctly.
Fix issue waarp#64
@fredericBregier fredericBregier added this to the 3.4.1 milestone Aug 11, 2020
@fredericBregier fredericBregier linked a pull request Aug 11, 2020 that will close this issue
@fredericBregier
Copy link
Collaborator

fredericBregier commented Aug 11, 2020

Fix in #71

fredericBregier added a commit to fredericBregier/Waarp-All that referenced this issue Aug 13, 2020
When client or server is loaded using no database, therefore using XMLDBDAO,
the rules were not loaded correctly.
Fix issue waarp#64
fredericBregier added a commit to fredericBregier/Waarp-All that referenced this issue Aug 28, 2020
When client or server is loaded using no database, therefore using XMLDBDAO,
the rules were not loaded correctly.
Fix issue waarp#64
fredericBregier added a commit that referenced this issue Aug 28, 2020
When client or server is loaded using no database, therefore using XMLDBDAO,
the rules were not loaded correctly.
Fix issue #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants