Fix issue #26 on DB Connection closed in Admin #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In admin interface, espcially in Responsive mode, the DbConnection sometimes seems closed and not reopened as it should be. Since the new model of connections is to not keep the connections opens but to reopen it as much as we need it (seems not to have big impact, and in particular for Web Admin interface, it should not have any impact), this fix removes the database keeping rule replacing by the underlying native pooling connections. This fix is made for all Admin Interface: R66, GWFTP, ProxyR66. This is only a fix for waarp#26, not an evolution.
fredericBregier
force-pushed
the
v3.3.3.httpsconnection
branch
from
fd7fe24
to
8db9e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In admin interface, espcially in Responsive mode, the DbConnection sometimes
seems closed and not reopened as it should be.
Since the new model of connections is to not keep the connections opens but to
reopen it as much as we need it (seems not to have big impact, and in particular
for Web Admin interface, it should not have any impact), this fix removes the
database keeping rule replacing by the underlying native pooling connections.
This fix is made for all Admin Interface: R66, GWFTP, ProxyR66.
This is only a fix for #26 , not an evolution.