New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in script --> Exit 1 in loop doesnt exit the script #14

Merged
merged 2 commits into from Sep 15, 2015

Conversation

Projects
None yet
2 participants
@janvandijk
Contributor

janvandijk commented Jun 12, 2015

An additional || exit $? is required to make it work.

See also http://stackoverflow.com/questions/29969093/exit-1-in-pre-commit-doesnt-abort-git-commit

@wadmiraal

This comment has been minimized.

Owner

wadmiraal commented Sep 15, 2015

Hi. Sorry, completely forgot about your PR! Thanks, will update the post.

wadmiraal added a commit that referenced this pull request Sep 15, 2015

Merge pull request #14 from janvandijk/master
	Fix bug in script --> Exit 1 in loop doesnt exit the script

@wadmiraal wadmiraal merged commit a0725ef into wadmiraal:master Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment