Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie.releasedate is an empty unicode string (u'') if no date is available #37

Open
stv0g opened this issue Feb 2, 2014 · 1 comment

Comments

@stv0g
Copy link

stv0g commented Feb 2, 2014

I'm not really sure if this is an intended behaviour.
I think "None" would be more adequate here.

@wagnerrp
Copy link
Owner

wagnerrp commented Feb 2, 2014

At the moment, all datapoints, if not defined otherwise, are handled as a unicode string and default to u''. Releasedate is configured to be handled as a date string, but is not given a proper default.

releasedate = Datapoint('release_date', handler=process_date)

The Person dates are configured how you are expecting.

dayofbirth = Datapoint('birthday', default=None, handler=process_date)
dayofdeath = Datapoint('deathday', default=None, handler=process_date)

There's a number of instances of this with values that should probably be handled as an integer or float. I'll need to go through and clean them up.

wagnerrp added a commit that referenced this issue Feb 7, 2014
This adds strict typing to various integer and float values. This also
converts ISO639 and ISO3166 strings to their internally stored version,
throwing a warning and returning None if there is no match. This is only
minimally tested, and could result in unintended consequences caused by
attributes that previously held strings.

Refs #37. Refs #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@stv0g @wagnerrp and others